Issue 141053003: Convert the re2 GYP targets to be generated by GN

Issue 141053003: Convert the re2 GYP targets to be generated by GN (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert the re2 GYP targets to be generated by GN. BUG=288991 R=bradnelson@google.com Reland of r245254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245563

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -181 lines)			Patch
M	build/all.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/profile_reset/jtl_compiler.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/plugins.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/url_matcher.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/extensions.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer_service.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gpu_config.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/leveldatabase/leveldatabase.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libaddressinput/libaddressinput.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	third_party/re2/BUILD.gn	View	2 chunks	+2 lines, -4 lines	1 comment	Download
D	third_party/re2/re2.gyp	View	1 chunk	+0 lines, -84 lines	0 comments	Download
D	tools/gn/secondary/third_party/re2/BUILD.gn	View	1 chunk	+0 lines, -77 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Harris

6 years, 11 months ago (2014-01-21 02:10:52 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/141053003/diff/1/third_party/re2/BUILD.gn
File third_party/re2/BUILD.gn (left):

https://codereview.chromium.org/141053003/diff/1/third_party/re2/BUILD.gn#old...
third_party/re2/BUILD.gn:73: # TODO(brettw) 'msvs_disabled_warnings': [ 4018,
4722, 4267 ],
FYI - this change seems to have generated a load of new warnings on the
win_x64_rel bot

Expand Messages | Collapse Messages