Chromium Code Reviews

Issue 1410523003: Aura on Android: Use Aura's snapshot implementaion with Android Aura. (Closed)

Created:
5 years, 2 months ago by mfomitchev
Modified:
5 years, 2 months ago
Reviewers:
sky, no sievers
CC:
chromium-reviews, bshe
Base URL:
https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_webview
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura on Android: Use Aura's snapshot implementaion with Android Aura. BUG=507792 Committed: https://crrev.com/17103c5d3352ef91364e2da122374ab229299fd3 Cr-Commit-Position: refs/heads/master@{#354407}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+5 lines, -1 line)
M ui/snapshot/BUILD.gn View 2 chunks +5 lines, -1 line 1 comment

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
mfomitchev
5 years, 2 months ago (2015-10-15 18:25:43 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-10-15 21:08:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410523003/1
5 years, 2 months ago (2015-10-15 21:29:27 UTC) #5
no sievers
https://codereview.chromium.org/1410523003/diff/1/ui/snapshot/BUILD.gn File ui/snapshot/BUILD.gn (right): https://codereview.chromium.org/1410523003/diff/1/ui/snapshot/BUILD.gn#newcode34 ui/snapshot/BUILD.gn:34: deps += [ "//ui/android" ] We should rename this ...
5 years, 2 months ago (2015-10-15 22:18:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 23:51:16 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 23:52:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17103c5d3352ef91364e2da122374ab229299fd3
Cr-Commit-Position: refs/heads/master@{#354407}

Powered by Google App Engine