Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/virtual-frame-ia32.cc

Issue 14105: Experimental: fix a pair of bugs in the frame's sync state. In two... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/virtual-frame-ia32.cc
===================================================================
--- src/virtual-frame-ia32.cc (revision 970)
+++ src/virtual-frame-ia32.cc (working copy)
@@ -475,6 +475,12 @@
} else {
// Source is constant.
__ Set(target.reg(), Immediate(source.handle()));
+ if (target.is_synced()) {
+ if (i > stack_pointer_) {
+ SyncRange(stack_pointer_ + 1, i);
+ }
+ SyncElementAt(i);
+ }
}
Use(target.reg());
elements_[i] = target;
@@ -624,12 +630,13 @@
cgen_->allocator()->Unuse(temp);
} else {
- // For constants and registers, add a copy of the element to the
- // top of the frame.
+ // For constants and registers, add an (unsynced) copy of the element to
+ // the top of the frame.
ASSERT(element.is_register() || element.is_constant());
if (element.is_register()) {
Use(element.reg());
}
+ element.clear_sync();
elements_.Add(element);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698