Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: src/js/arraybuffer.js

Issue 1410473002: Reland: Use simple/fast inline function version of MinMax in JS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: use existing export in runtime Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/js/arraybuffer.js
diff --git a/src/js/arraybuffer.js b/src/js/arraybuffer.js
index fb803caa5aace679c621158f2ce0f44bd55216d4..dcb968c88bd1ea6afc14dc8ac1b1e88b9cfde797 100644
--- a/src/js/arraybuffer.js
+++ b/src/js/arraybuffer.js
@@ -13,14 +13,17 @@
var GlobalArrayBuffer = global.ArrayBuffer;
var GlobalObject = global.Object;
-var MathMax;
-var MathMin;
var ToPositiveInteger;
var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");
+var MaxSimple;
Jakob Kummerow 2015/10/15 14:18:48 nit: please preserve alpha-sorting
skomski 2015/10/15 15:17:58 Done.
+var MinSimple;
+
+utils.Import(function(from) {
+ MaxSimple = from.MaxSimple;
+ MinSimple = from.MinSimple;
+});
utils.Import(function(from) {
- MathMax = from.MathMax;
- MathMin = from.MathMin;
ToPositiveInteger = from.ToPositiveInteger;
});
@@ -57,16 +60,16 @@ function ArrayBufferSlice(start, end) {
var first;
var byte_length = %_ArrayBufferGetByteLength(this);
if (relativeStart < 0) {
- first = MathMax(byte_length + relativeStart, 0);
+ first = MaxSimple(byte_length + relativeStart, 0);
} else {
- first = MathMin(relativeStart, byte_length);
+ first = MinSimple(relativeStart, byte_length);
}
var relativeEnd = IS_UNDEFINED(end) ? byte_length : end;
var fin;
if (relativeEnd < 0) {
- fin = MathMax(byte_length + relativeEnd, 0);
+ fin = MaxSimple(byte_length + relativeEnd, 0);
} else {
- fin = MathMin(relativeEnd, byte_length);
+ fin = MinSimple(relativeEnd, byte_length);
}
if (fin < first) {

Powered by Google App Engine
This is Rietveld 408576698