src/js/macros.py - Issue 1410473002: Reland: Use simple/fast inline function version of MinMax in JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/macros.py

Issue 1410473002: Reland: Use simple/fast inline function version of MinMax in JS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: after yangs fix possible to use utils.ImportNow in test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/macros.py

diff --git a/src/js/macros.py b/src/js/macros.py

index 8259ee8da526cbac3819f833c2516455e0738731..48e3d4ac88817d619b6eabb12997a0df43f80790 100644

--- a/src/js/macros.py

+++ b/src/js/macros.py

@@ -159,8 +159,6 @@ macro TO_NAME(arg) = (%_ToName(arg));

macro JSON_NUMBER_TO_STRING(arg) = ((%_IsSmi(%IS_VAR(arg)) || arg - arg == 0) ? %_NumberToString(arg) : "null");

macro HAS_OWN_PROPERTY(arg, index) = (%_CallFunction(arg, index, ObjectHasOwnProperty));

macro HAS_INDEX(array, index, is_array) = ((is_array && %_HasFastPackedElements(%IS_VAR(array))) ? (index < array.length) : (index in array));

-macro MAX_SIMPLE(argA, argB) = (argA < argB ? argB : argA);

-macro MIN_SIMPLE(argA, argB) = (argA < argB ? argA : argB);

# Private names.

macro IS_PRIVATE(sym) = (%SymbolIsPrivate(sym));

« no previous file with comments | « src/js/json.js ('k') | src/js/prologue.js » ('j') | no next file with comments »