src/js/array.js - Issue 1410473002: Reland: Use simple/fast inline function version of MinMax in JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/array.js

Issue 1410473002: Reland: Use simple/fast inline function version of MinMax in JS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: after yangs fix possible to use utils.ImportNow in test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/array.js

diff --git a/src/js/array.js b/src/js/array.js

index 4b994e272ad47e26bbcf7a6f56f27d50b9b23a9f..8358a68831374360afe45ec1239dc6586b3dd77a 100644

--- a/src/js/array.js

+++ b/src/js/array.js

@@ -16,7 +16,7 @@ var FLAG_harmony_tolength;

var GlobalArray = global.Array;

var InternalArray = utils.InternalArray;

var InternalPackedArray = utils.InternalPackedArray;

-var MathMin;

+var MinSimple;

var ObjectHasOwnProperty;

var ObjectIsFrozen;

var ObjectIsSealed;

@@ -28,7 +28,7 @@ var unscopablesSymbol = utils.ImportNow("unscopables_symbol");

utils.Import(function(from) {

Delete = from.Delete;

- MathMin = from.MathMin;

+ MinSimple = from.MinSimple;

ObjectHasOwnProperty = from.ObjectHasOwnProperty;

ObjectIsFrozen = from.ObjectIsFrozen;

ObjectIsSealed = from.ObjectIsSealed;

@@ -271,7 +271,7 @@ function SparseMove(array, start_i, del_count, len, num_additional_args) {

// Move data to new array.

var new_array = new InternalArray(

// Clamp array length to 2^32-1 to avoid early RangeError.

- MathMin(len - del_count + num_additional_args, 0xffffffff));

+ MinSimple(len - del_count + num_additional_args, 0xffffffff));

var big_indices;

var indices = %GetArrayKeys(array, len);

if (IS_NUMBER(indices)) {

« no previous file with comments | « no previous file | src/js/arraybuffer.js » ('j') | no next file with comments »