Reland: Use simple/fast inline function version of MinMax in JS

src/js/arraybuffer.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
 // -------------------------------------------------------------------
 // Imports
 
 var GlobalArrayBuffer = global.ArrayBuffer;
 var GlobalObject = global.Object;
-var MathMax;
-var MathMin;
 var ToPositiveInteger;
 var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");
+var MaxSimple;

[Jakob Kummerow, 2015/10/15 14:18:48]

nit: please preserve alpha-sorting

[skomski, 2015/10/15 15:17:58]

Done.

+var MinSimple;
 
 utils.Import(function(from) {
-  MathMax = from.MathMax;
-  MathMin = from.MathMin;
+  MaxSimple = from.MaxSimple;
+  MinSimple = from.MinSimple;
+});
+
+utils.Import(function(from) {
   ToPositiveInteger = from.ToPositiveInteger;
 });
 
 // -------------------------------------------------------------------
 
 function ArrayBufferConstructor(length) { // length = 1
   if (%_IsConstructCall()) {
     var byteLength = ToPositiveInteger(length, kInvalidArrayBufferLength);
     %ArrayBufferInitialize(this, byteLength, kNotShared);
   } else {
@@ skipping 16 matching lines @@
                         'ArrayBuffer.prototype.slice', this);
   }
 
   var relativeStart = TO_INTEGER(start);
   if (!IS_UNDEFINED(end)) {
     end = TO_INTEGER(end);
   }
   var first;
   var byte_length = %_ArrayBufferGetByteLength(this);
   if (relativeStart < 0) {
-    first = MathMax(byte_length + relativeStart, 0);
+    first = MaxSimple(byte_length + relativeStart, 0);
   } else {
-    first = MathMin(relativeStart, byte_length);
+    first = MinSimple(relativeStart, byte_length);
   }
   var relativeEnd = IS_UNDEFINED(end) ? byte_length : end;
   var fin;
   if (relativeEnd < 0) {
-    fin = MathMax(byte_length + relativeEnd, 0);
+    fin = MaxSimple(byte_length + relativeEnd, 0);
   } else {
-    fin = MathMin(relativeEnd, byte_length);
+    fin = MinSimple(relativeEnd, byte_length);
   }
 
   if (fin < first) {
     fin = first;
   }
   var newLen = fin - first;
   // TODO(dslomov): implement inheritance
   var result = new GlobalArrayBuffer(newLen);
 
   %ArrayBufferSliceImpl(this, result, first);
@@ skipping 21 matching lines @@
 
 utils.InstallFunctions(GlobalArrayBuffer, DONT_ENUM, [
   "isView", ArrayBufferIsViewJS
 ]);
 
 utils.InstallFunctions(GlobalArrayBuffer.prototype, DONT_ENUM, [
   "slice", ArrayBufferSlice
 ]);
 
 })