Reland: Use simple/fast inline function version of MinMax in JS

src/js/harmony-typedarray.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
@@ skipping 30 matching lines @@
 var InnerArrayFindIndex;
 var InnerArrayForEach;
 var InnerArrayIndexOf;
 var InnerArrayJoin;
 var InnerArrayLastIndexOf;
 var InnerArrayMap;
 var InnerArraySome;
 var InnerArraySort;
 var InnerArrayToLocaleString;
 var IsNaN;
-var MathMax;
-var MathMin;
+var MaxSimple;
+var MinSimple;
 var PackedArrayReverse;
 
 utils.Import(function(from) {
   ArrayFrom = from.ArrayFrom;
   ArrayToString = from.ArrayToString;
   InnerArrayCopyWithin = from.InnerArrayCopyWithin;
   InnerArrayEvery = from.InnerArrayEvery;
   InnerArrayFill = from.InnerArrayFill;
   InnerArrayFilter = from.InnerArrayFilter;
   InnerArrayFind = from.InnerArrayFind;
   InnerArrayFindIndex = from.InnerArrayFindIndex;
   InnerArrayForEach = from.InnerArrayForEach;
   InnerArrayIndexOf = from.InnerArrayIndexOf;
   InnerArrayJoin = from.InnerArrayJoin;
   InnerArrayLastIndexOf = from.InnerArrayLastIndexOf;
   InnerArrayMap = from.InnerArrayMap;
   InnerArrayReduce = from.InnerArrayReduce;
   InnerArrayReduceRight = from.InnerArrayReduceRight;
   InnerArraySome = from.InnerArraySome;
   InnerArraySort = from.InnerArraySort;
   InnerArrayToLocaleString = from.InnerArrayToLocaleString;
   IsNaN = from.IsNaN;
-  MathMax = from.MathMax;
-  MathMin = from.MathMin;
+  MaxSimple = from.MaxSimple;
+  MinSimple = from.MinSimple;
   PackedArrayReverse = from.PackedArrayReverse;
 });
 
 // -------------------------------------------------------------------
 
 function ConstructTypedArray(constructor, arg) {
   // TODO(littledan): This is an approximation of the spec, which requires
   // that only real TypedArray classes should be accepted (22.2.2.1.1)
   if (!%IsConstructor(constructor) || IS_UNDEFINED(constructor.prototype) ||
       !%HasOwnProperty(constructor.prototype, "BYTES_PER_ELEMENT")) {
@@ skipping 225 matching lines @@
 
 
 function TypedArraySlice(start, end) {
   if (!%_IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
   var len = %_TypedArrayGetLength(this);
 
   var relativeStart = TO_INTEGER(start);
 
   var k;
   if (relativeStart < 0) {
-    k = MathMax(len + relativeStart, 0);
+    k = MaxSimple(len + relativeStart, 0);
   } else {
-    k = MathMin(relativeStart, len);
+    k = MinSimple(relativeStart, len);
   }
 
   var relativeEnd;
   if (IS_UNDEFINED(end)) {
     relativeEnd = len;
   } else {
     relativeEnd = TO_INTEGER(end);
   }
 
   var final;
   if (relativeEnd < 0) {
-    final = MathMax(len + relativeEnd, 0);
+    final = MaxSimple(len + relativeEnd, 0);
   } else {
-    final = MathMin(relativeEnd, len);
+    final = MinSimple(relativeEnd, len);
   }
 
-  var count = MathMax(final - k, 0);
+  var count = MaxSimple(final - k, 0);
   var array = ConstructTypedArrayLike(this, count);
   // The code below is the 'then' branch; the 'else' branch species
   // a memcpy. Because V8 doesn't canonicalize NaN, the difference is
   // unobservable.
   var n = 0;
   while (k < final) {
     var kValue = this[k];
     // TODO(littledan): The spec says to throw on an error in setting;
     // does this throw?
     array[n] = kValue;
@@ skipping 51 matching lines @@
     "some", TypedArraySome,
     "sort", TypedArraySort,
     "toString", TypedArrayToString,
     "toLocaleString", TypedArrayToLocaleString
   ]);
 endmacro
 
 TYPED_ARRAYS(EXTEND_TYPED_ARRAY)
 
 })