8 years, 10 months ago
(2009-06-22 12:32:48 UTC)
#3
LGTM
http://codereview.chromium.org/141042/diff/6/1004
File src/jsregexp.cc (right):
http://codereview.chromium.org/141042/diff/6/1004#newcode408
Line 408: (IrregexpNumberOfCaptures(FixedArray::cast(jsregexp->data())) + 1) * 2
:
Seems this have different meanings for the two implementations.
For native irregexp, it really is number of *capture* registers, but for the
interpreter it is number of registers total.
How about moving it into the branches of the conditional, so each branch can
have its own code (and properly named variables).
Issue 141042: Fix regexp bug reported on iit.edu.
(Closed)
Created 8 years, 10 months ago by Erik Corry
Modified 6 years, 11 months ago
Reviewers: Lasse Reichstein
Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Comments: 1