Chromium Code Reviews
Help | Chromium Project | Sign in
(340)

Issue 141042: Fix regexp bug reported on iit.edu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Erik Corry
Modified:
2 years, 11 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Fix regexp bug reported on iit.edu.

Committed: http://code.google.com/p/v8/source/detail?r=2235

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Lint Patch
M src/jsregexp.cc View 1 2 chunks +6 lines, -3 lines 1 comment 0 errors Download
A test/mjsunit/regexp-captures.js View 1 chunk +31 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Erik Corry
4 years, 10 months ago #1
Lasse Reichstein
LGTM
4 years, 10 months ago #2
Lasse Reichstein
4 years, 10 months ago #3
LGTM

http://codereview.chromium.org/141042/diff/6/1004
File src/jsregexp.cc (right):

http://codereview.chromium.org/141042/diff/6/1004#newcode408
Line 408: (IrregexpNumberOfCaptures(FixedArray::cast(jsregexp->data())) + 1) * 2
:
Seems this have different meanings for the two implementations.
For native irregexp, it really is number of *capture* registers, but for the
interpreter it is number of registers total.
How about moving it into the branches of the conditional, so each branch can
have its own code (and properly named variables).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6