Issue 141042: Fix regexp bug reported on iit.edu.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 141042: Fix regexp bug reported on iit.edu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 8 months ago by Erik Corry

Modified:
2 years, 10 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev_googlegroups.com

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

    Fix regexp bug reported on iit.edu.

Committed: http://code.google.com/p/v8/source/detail?r=2235

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Lint	Patch
	A	test/mjsunit/regexp-captures.js	View		1 chunk	+31 lines, -0 lines	0 comments	0 errors	Download
	M	src/jsregexp.cc	View	1	2 chunks	+6 lines, -3 lines	1 comment	0 errors	Download

Trybot results:

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Lasse Reichstein

4 years, 8 months ago #3

LGTM

http://codereview.chromium.org/141042/diff/6/1004
File src/jsregexp.cc (right):

http://codereview.chromium.org/141042/diff/6/1004#newcode408
Line 408: (IrregexpNumberOfCaptures(FixedArray::cast(jsregexp->data())) + 1) * 2
:
Seems this have different meanings for the two implementations.
For native irregexp, it really is number of *capture* registers, but for the
interpreter it is number of registers total.
How about moving it into the branches of the conditional, so each branch can
have its own code (and properly named variables).

Expand All Messages | Collapse All Messages