Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1410413008: Attempt again to upstream Xcode project version warning suppression, from 1416453003 and 1430573009… (Closed)

Created:
5 years, 1 month ago by aharper
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com, altse1, scottmg
Base URL:
https://chromium.googlesource.com/external/gyp@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Attempt again to upstream Xcode project version warning suppression, from 1416453003 and 1430573009, and rolled back in 1423583004. R=mark@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/2dd620e103297b09b141a28d707abd7d2ce399d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M pylib/gyp/generator/xcode.py View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
aharper
5 years, 1 month ago (2015-11-06 20:12:05 UTC) #1
Mark Mentovai
-mmentovai@chromium.org (who is that?) +mark@chromium.org
5 years, 1 month ago (2015-11-06 20:14:40 UTC) #6
Mark Mentovai
Tests are OK, LGTM.
5 years, 1 month ago (2015-11-06 20:26:32 UTC) #7
Mark Mentovai
5 years, 1 month ago (2015-11-06 20:27:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2dd620e103297b09b141a28d707abd7d2ce399d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698