Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1410413007: ExclusiveAccessBubbleViews: Use BoxLayout instead of GridLayout. (Closed)

Created:
5 years, 1 month ago by Matt Giuca
Modified:
5 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExclusiveAccessBubbleViews: Use BoxLayout instead of GridLayout. BoxLayout is more appropriate, and does not suffer the 'invisible children still take up space' issue of GridLayout (crbug.com/548551). (There is a work-around for this issue with Label, but not with other view types which we'll need in the future.) Removed the code for Label and ButtonView to make their GetPreferredSize return 0 when hidden (no longer necessary). This CL should not have any observable effect. BUG=352425 Committed: https://crrev.com/0c1375df4d18383c937632d9b126e6a118096c63 Cr-Commit-Position: refs/heads/master@{#358238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -35 lines) Patch
M chrome/browser/ui/views/exclusive_access_bubble_views.cc View 5 chunks +6 lines, -35 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Matt Giuca
Note: Following from a discussion with sadrul@ on https://codereview.chromium.org/1422703004/; it may be good to fix ...
5 years, 1 month ago (2015-11-05 06:07:45 UTC) #2
msw
It'd be nice to see some before/after pics to ensure the layout remains as expected, ...
5 years, 1 month ago (2015-11-05 18:54:28 UTC) #3
Matt Giuca
On 2015/11/05 18:54:28, msw wrote: > It'd be nice to see some before/after pics to ...
5 years, 1 month ago (2015-11-06 01:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410413007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410413007/1
5 years, 1 month ago (2015-11-06 01:56:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 02:34:38 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 02:35:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c1375df4d18383c937632d9b126e6a118096c63
Cr-Commit-Position: refs/heads/master@{#358238}

Powered by Google App Engine
This is Rietveld 408576698