Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1410403003: Switch Js to JS (Closed)

Created:
5 years, 2 months ago by Jacob
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/js/lib/js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_array_test.dart View 4 chunks +29 lines, -29 lines 0 comments Download
M tests/html/js_dart_to_string_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/js_typed_interop_test.dart View 7 chunks +10 lines, -10 lines 0 comments Download
M tests/html/json_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/mirrors_js_typed_interop_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Siggi Cherem (dart-lang)
lgtm :)
5 years, 2 months ago (2015-10-20 00:28:51 UTC) #2
Jacob
5 years, 2 months ago (2015-10-20 00:32:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
be1fcb944176bed2bf1294c78cd39844df67dda6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698