Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1410393006: [turbofan] Fix representation type for JSArray::length. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix representation type for JSArray::length. This fixes the representation type for values in JSArray::length fields when JSNativeContextSpecialization lowers loads. Only arrays with fast elements kind are guaranteed to have a Smi represented length. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-4515 BUG=v8:4515, v8:4493, v8:4470 LOG=n Committed: https://crrev.com/e121aabe3929069246b33edd71ffff355c3bb0e6 Cr-Commit-Position: refs/heads/master@{#31558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-4515.js View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-26 11:46:54 UTC) #1
Benedikt Meurer
Thanks for fixing. LGTM
5 years, 1 month ago (2015-10-26 11:50:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410393006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410393006/1
5 years, 1 month ago (2015-10-26 11:56:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 12:04:10 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 12:04:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e121aabe3929069246b33edd71ffff355c3bb0e6
Cr-Commit-Position: refs/heads/master@{#31558}

Powered by Google App Engine
This is Rietveld 408576698