Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1410393004: X87: Re-reland: Remove register index/code indirection. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Re-reland: Remove register index/code indirection. port 5cf1c0bcf6f10ff61a95a00fa302eeee7c390885 (r31087). original commit message: Previous to this patch, both the lithium and TurboFan register allocators tracked allocated registers by "indices", rather than the register codes used elsewhere in the runtime. This patch ensures that codes are used everywhere, and in the process cleans up a bunch of redundant code and adds more structure to how the set of allocatable registers is defined. Some highlights of changes: * TurboFan's RegisterConfiguration class moved to V8's top level so that it can be shared with Crankshaft. * Various "ToAllocationIndex" and related methods removed. * Code that can be easily shared between Register classes on different platforms is now shared. * The list of allocatable registers on each platform is declared as a list rather than implicitly via the register index <-> code mapping. additional comment: This patch must be work with CL https://codereview.chromium.org/1405673003/ and CL https://codereview.chromium.org/1413343002/ which provide the needed register allocation common code change in v8 for this CL BUG= Committed: https://crrev.com/2e5845f178b2fc52d9a344f35b50d27a6d45fd03 Cr-Commit-Position: refs/heads/master@{#31494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -150 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-gap-resolver-x87.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-gap-resolver-x87.cc View 7 chunks +27 lines, -17 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/x87/assembler-x87.h View 2 chunks +84 lines, -89 lines 0 comments Download
M src/x87/code-stubs-x87.h View 1 chunk +9 lines, -7 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +10 lines, -10 lines 0 comments Download
M test/cctest/test-code-stubs-x87.cc View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
zhengxing.li
help to review this patch, Thanks!
5 years, 1 month ago (2015-10-23 07:03:52 UTC) #2
zhengxing.li
5 years, 1 month ago (2015-10-23 07:06:29 UTC) #4
Weiliang
lgtm
5 years, 1 month ago (2015-10-23 07:11:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410393004/1
5 years, 1 month ago (2015-10-23 07:57:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-23 07:58:24 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-23 07:58:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e5845f178b2fc52d9a344f35b50d27a6d45fd03
Cr-Commit-Position: refs/heads/master@{#31494}

Powered by Google App Engine
This is Rietveld 408576698