Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1410373006:
Fix weak processing over cleared hash tables. (Closed)
DescriptionFix weak processing over cleared hash tables.
When a hash table of weak references is traced during the GC
marking phase, a weak callback is registered for processing after
that initial marking pass.
The hash table may be populated with entries at the time when
that weak callback is registered, but may end up being cleared
before the weak callback actually gets to run.
Account for that latter possibility by having the weak callback
being invoked first gracefully check if the backing table exists
before proceeding to process it.
R=haraken
BUG=549732
NOTRY=true
Committed: https://crrev.com/2a08258a857e6730f3cd11552944f74e1b79ec51
Cr-Commit-Position: refs/heads/master@{#357282}
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org, tkent@chromium.org
please take a look.
Description was changed from ========== Fix weak tracing over cleared hash tables. When a hash table of weak references is traced during the GC marking phase, a weak callback is registered for processing after that initial marking pass. The hash table may be populated with entries at the time when that weak callback is registered, but may end up being cleared before the weak callback actually gets to run. Account for that latter possibility by having the weak callback being invoked first gracefully check if the backing table exists before proceeding to process it. R= BUG=549732 ========== to ========== Fix weak processing over cleared hash tables. When a hash table of weak references is traced during the GC marking phase, a weak callback is registered for processing after that initial marking pass. The hash table may be populated with entries at the time when that weak callback is registered, but may end up being cleared before the weak callback actually gets to run. Account for that latter possibility by having the weak callback being invoked first gracefully check if the backing table exists before proceeding to process it. R= BUG=549732 ==========
LGTM, thanks for the fix!
Description was changed from ========== Fix weak processing over cleared hash tables. When a hash table of weak references is traced during the GC marking phase, a weak callback is registered for processing after that initial marking pass. The hash table may be populated with entries at the time when that weak callback is registered, but may end up being cleared before the weak callback actually gets to run. Account for that latter possibility by having the weak callback being invoked first gracefully check if the backing table exists before proceeding to process it. R= BUG=549732 ========== to ========== Fix weak processing over cleared hash tables. When a hash table of weak references is traced during the GC marking phase, a weak callback is registered for processing after that initial marking pass. The hash table may be populated with entries at the time when that weak callback is registered, but may end up being cleared before the weak callback actually gets to run. Account for that latter possibility by having the weak callback being invoked first gracefully check if the backing table exists before proceeding to process it. R=haraken BUG=549732 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410373006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410373006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410373006/1
Description was changed from ========== Fix weak processing over cleared hash tables. When a hash table of weak references is traced during the GC marking phase, a weak callback is registered for processing after that initial marking pass. The hash table may be populated with entries at the time when that weak callback is registered, but may end up being cleared before the weak callback actually gets to run. Account for that latter possibility by having the weak callback being invoked first gracefully check if the backing table exists before proceeding to process it. R=haraken BUG=549732 ========== to ========== Fix weak processing over cleared hash tables. When a hash table of weak references is traced during the GC marking phase, a weak callback is registered for processing after that initial marking pass. The hash table may be populated with entries at the time when that weak callback is registered, but may end up being cleared before the weak callback actually gets to run. Account for that latter possibility by having the weak callback being invoked first gracefully check if the backing table exists before proceeding to process it. R=haraken BUG=549732 NOTRY=true ==========
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410373006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2a08258a857e6730f3cd11552944f74e1b79ec51 Cr-Commit-Position: refs/heads/master@{#357282} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
