runtime/vm/regexp_assembler_ir.cc - Issue 1410363005: Make ICData changes thread safe (first compute array, then set it). Install code in the main thread…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp_assembler_ir.cc

Issue 1410363005: Make ICData changes thread safe (first compute array, then set it). Install code in the main thread… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/regexp_assembler_ir.cc

diff --git a/runtime/vm/regexp_assembler_ir.cc b/runtime/vm/regexp_assembler_ir.cc

index 82c314fec763ac3934639acfd3455609214ad52e..7d4cff24286a1c8eeafa0ae8044e68622a93be2e 100644

--- a/runtime/vm/regexp_assembler_ir.cc

+++ b/runtime/vm/regexp_assembler_ir.cc

@@ -112,7 +112,7 @@ IRRegExpMacroAssembler::IRRegExpMacroAssembler(

new(zone) GraphEntryInstr(

*parsed_function_,

new(zone) TargetEntryInstr(block_id_.Alloc(), kInvalidTryIndex),

- Thread::kNoDeoptId);

+ Compiler::kNoOSRDeoptId);

start_block_ =

new(zone) JoinEntryInstr(block_id_.Alloc(), kInvalidTryIndex);

success_block_ =

« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »