Make ICData changes thread safe (first compute array, then set it). Install code in the main thread…

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/atomic.h"
@@ skipping 591 matching lines @@
 
   RawGrowableObjectArray* tag_table() const { return tag_table_; }
   void set_tag_table(const GrowableObjectArray& value);
 
   RawUserTag* current_tag() const { return current_tag_; }
   void set_current_tag(const UserTag& tag);
 
   RawUserTag* default_tag() const { return default_tag_; }
   void set_default_tag(const UserTag& tag);
 
-  RawGrowableObjectArray* background_compilation_queue() const {
-    return background_compilation_queue_;
+  RawGrowableObjectArray* compilation_function_queue() const {
+    return compilation_function_queue_;
   }
-  void set_background_compilation_queue(const GrowableObjectArray& value);
+  void set_compilation_function_queue(const GrowableObjectArray& value);
+
+  RawGrowableObjectArray* compilation_code_queue() const {
+    return compilation_code_queue_;
+  }
+  void set_compilation_code_queue(const GrowableObjectArray& value);
 
   Metric* metrics_list_head() {
     return metrics_list_head_;
   }
 
   void set_metrics_list_head(Metric* metric) {
     metrics_list_head_ = metric;
   }
 
   RawGrowableObjectArray* deoptimized_code_array() const {
@@ skipping 170 matching lines @@
   IsolateProfilerData* profiler_data_;
   Mutex profiler_data_mutex_;
 
   VMTagCounters vm_tag_counters_;
   RawGrowableObjectArray* tag_table_;
 
   RawGrowableObjectArray* deoptimized_code_array_;
 
   // Background compilation.
   BackgroundCompiler* background_compiler_;
-  RawGrowableObjectArray* background_compilation_queue_;
+  RawGrowableObjectArray* compilation_function_queue_;
+  RawGrowableObjectArray* compilation_code_queue_;
 
   // We use 6 list entries for each pending service extension calls.
   enum {
     kPendingHandlerIndex = 0,
     kPendingMethodNameIndex,
     kPendingKeysIndex,
     kPendingValuesIndex,
     kPendingReplyPortIndex,
     kPendingIdIndex,
     kPendingEntrySize
@@ skipping 208 matching lines @@
   uint8_t* serialized_message_;
   intptr_t serialized_message_len_;
   Isolate::Flags isolate_flags_;
   bool paused_;
   bool errors_are_fatal_;
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_