chrome/ct_top1k.isolate.tmpl - Issue 1410353007: Add CT isolate file and CT script that will be run on swarming slaves

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/ct_top1k.isolate.tmpl

Issue 1410353007: Add CT isolate file and CT script that will be run on swarming slaves (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move wprs to telemetry data dir Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'includes': [

	7 # TODO(rmistry): Uncomment below when the solution to discussion in

	8 # crrev.com/1423993007/diff/440001/scripts/slave/recipes/perf/ct_top1k_rr_pe rf.py#newcode143 is found.

	9 # '../tools/telemetry/telemetry.isolate',

	10 '../tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate',
	nednguyen 2015/11/13 18:24:39 Telemetry & perf dependencies can be found fully d Telemetry & perf dependencies can be found fully described with https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/perf.is... If not, we should add more deps to that isolate instead. rmistry 2015/11/16 16:31:49 I get this error when I use perf.isolate when runn Show quoted text On 2015/11/13 18:24:39, nednguyen wrote: > Telemetry & perf dependencies can be found fully described with > https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/perf.is... > > > If not, we should add more deps to that isolate instead. I get this error when I use perf.isolate when running locally: IsolateError: These configuration variables were missing from the command line: CONFIGURATION_NAME, asan, component, disable_nacl, fastbuild, icu_use_data_file_flag, kasko, lsan, msan, msvs_version, target_arch, tsan, use_custom_libcxx, use_instrumented_libraries, use_prebuilt_instrumented_libraries, v8_use_external_startup_data It could be that those variables are automatically provided when running on the waterfall. I'll turn it on once its live to see what happens. Updated the TODO.
	11 ],

	12 'conditions': [

	13 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {

	14 'variables': {

	15 'files': [

	16 '../build/android/pylib/',

	17 '../build/android/devil/',

	18 '../third_party/catapult/',

	19 '../tools/telemetry/',

	20 '../tools/perf/',

	21 '../tools/variations/',

	22 '../testing/test_env.py',

	23 '../out/Release/',

	24

	25 '../content/test/ct/run_ct_top1k.py',

	26 '../content/test/ct/path_util.py',

	27 '../content/test/ct/slave[[SLAVE_NUM]]/page_sets/',

	28 '../content/test/ct/run_chromium_perf_swarming',

	29 ],

	30 'command': [

	31 'python',

	32 '../content/test/ct/run_ct_top1k.py',

	33 '--slave_num=[[SLAVE_NUM]]',

	34 '--benchmark=[[BENCHMARK]]',

	35 '--master=[[MASTER]]',

	36 '--builder=[[BUILDER]]',

	37 '--git_hash=[[GIT_HASH]]',

	38 ],

	39 },

	40 }],

	41 ]

	42 }

OLD	NEW

« no previous file with comments | « no previous file | content/test/ct/path_util.py » ('j') | content/test/ct/run_ct_top1k.py » ('J')