Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(107)

Issue 1410353005: Add generic.total_physical_bytes property to MallocExtension (Closed)

Created:
4 years, 1 month ago by ssid
Modified:
4 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, tracing+reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@web_cache2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add generic.total_physical_bytes property to MallocExtension The actual physical memory usage of tcmalloc cannot be obtained by GetNumericProperty. This accounts for the current_allocated_bytes, fragmentation and malloc metadata, and excludes the unmapped memory regions. This helps the user to understand how much memory is actually being used for the allocations that were made. This change is done only in chromium tree since the metadata_unmapped_bytes is added only in the chromium's tcmalloc in CL: www.crrev.com/10499004. This is to be used by malloc dump provider for tracing. BUG=546491 Committed: https://crrev.com/0752ec9c6adf641985db1a3a224bf9b8e32e4ac8 Cr-Commit-Position: refs/heads/master@{#357155}

Patch Set 1 #

Patch Set 2 : Add in readme. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M base/trace_event/malloc_dump_provider.cc View 1 chunk +1 line, -11 lines 0 comments Download
M third_party/tcmalloc/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/tcmalloc.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
ssid
+wfh This changes the tcmalloc files to return the bytes used by metadata, which currently ...
4 years, 1 month ago (2015-10-27 11:48:52 UTC) #2
Primiano Tucci (use gerrit)
LGTM for base/trace_event. Note: I think you need to add one line to the "Modifications:" ...
4 years, 1 month ago (2015-10-27 17:05:41 UTC) #4
ssid
Added readme. wfh@ PTAL, Thanks.
4 years, 1 month ago (2015-10-30 14:02:31 UTC) #5
Will Harris
lgtm. Sorry for delay.
4 years, 1 month ago (2015-10-30 16:33:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410353005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410353005/20001
4 years, 1 month ago (2015-10-30 16:49:16 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2015-10-30 18:26:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410353005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410353005/20001
4 years, 1 month ago (2015-10-30 18:30:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2015-10-30 18:47:48 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2015-10-30 18:49:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0752ec9c6adf641985db1a3a224bf9b8e32e4ac8
Cr-Commit-Position: refs/heads/master@{#357155}

Powered by Google App Engine
This is Rietveld 408576698