Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410353002: [turbofan] Rename JSGlobalSpecialization to JSNativeContextSpecialization. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rename JSGlobalSpecialization to JSNativeContextSpecialization. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/f6a886d5715fbd98b2059d038e7eea1670d67e40 Cr-Commit-Position: refs/heads/master@{#31356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -804 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D src/compiler/js-global-specialization.h View 1 chunk +0 lines, -95 lines 0 comments Download
D src/compiler/js-global-specialization.cc View 1 chunk +0 lines, -661 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + src/compiler/js-native-context-specialization.h View 4 chunks +13 lines, -11 lines 0 comments Download
A + src/compiler/js-native-context-specialization.cc View 12 chunks +26 lines, -23 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-19 07:24:19 UTC) #1
Benedikt Meurer
Hey Jaro, Renaming as requested. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-19 07:24:47 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-19 07:38:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410353002/1
5 years, 2 months ago (2015-10-19 07:38:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 08:20:56 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 08:21:17 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f6a886d5715fbd98b2059d038e7eea1670d67e40
Cr-Commit-Position: refs/heads/master@{#31356}

Powered by Google App Engine
This is Rietveld 408576698