Issue 141035: Refactor the favicon loader out of gtk/options/general_page_gtk to gtk/list_store_favicon_loader,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141035: Refactor the favicon loader out of gtk/options/general_page_gtk to gtk/list_store_favicon_loader, (Closed)

Created:
11 years, 6 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Refactor the favicon loader out of gtk/options/general_page_gtk to gtk/list_store_favicon_loader, so that it can be used by the url_picker_dialog_gtk as well. BUG=11507 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18919

Patch Set 1 #

Total comments: 1

Patch Set 2 : consolidate line 28 and 30 #

Patch Set 3 : rebase #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -82 lines)			Patch
A	chrome/browser/gtk/list_store_favicon_loader.h	View		1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/list_store_favicon_loader.cc	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/options/general_page_gtk.h	View	1 2	3 chunks	+4 lines, -14 lines	0 comments	Download
M	chrome/browser/gtk/options/general_page_gtk.cc	View	1 2	5 chunks	+7 lines, -68 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 6 months ago (2009-06-22 17:08:43 UTC) #2

lgtm

http://codereview.chromium.org/141035/diff/1/2
File chrome/browser/gtk/list_store_favicon_loader.cc (right):

http://codereview.chromium.org/141035/diff/1/2#newcode28
Line 28: HistoryService::Handle handle(0);
consolidate line 28 and 30?

Expand Messages | Collapse Messages