Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1410343016: [turbofan] Introduce a Function type and optimize based on it. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a Function type and optimize based on it. This inserts a new bit set type Function, which is used to represent JSFunctions, and uses that type in typed lowering to optimize calls to use the CallFunction builtin directly. Also allows for better typing of the typeof operator, which can infern "function" for JSFunctions properly. R=jarin@chromium.org Committed: https://crrev.com/dc3c84812a4583271338936ae78d70e5d8dbe228 Cr-Commit-Position: refs/heads/master@{#31827}

Patch Set 1 #

Patch Set 2 : Undo unrelated change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -8 lines) Patch
M src/code-factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/types.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/types.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-05 12:41:04 UTC) #1
Benedikt Meurer
Hey Jaro, As discussed earlier, the Function bitset type is back now (OKed with Andreas). ...
5 years, 1 month ago (2015-11-05 12:42:02 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-05 12:48:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343016/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343016/1
5 years, 1 month ago (2015-11-05 12:49:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343016/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343016/20001
5 years, 1 month ago (2015-11-05 12:59:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 13:30:46 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 13:31:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc3c84812a4583271338936ae78d70e5d8dbe228
Cr-Commit-Position: refs/heads/master@{#31827}

Powered by Google App Engine
This is Rietveld 408576698