Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Issue 1410343011: Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away" (Closed)

Created:
5 years, 1 month ago by reed1
Modified:
5 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away" Fixed assert in test that was calling GrRecordReplaceDraw(). That function now uses drawBitmap, so updated the test to check for that (instead of drawSprite). This reverts commit 21b766347064837e6b78d600755901aad88cd6e0. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/7b81994d95f10cda80ddb85af68a2651ff31782f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M samplecode/SampleAll.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343011/1
5 years, 1 month ago (2015-11-03 14:58:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7b81994d95f10cda80ddb85af68a2651ff31782f
5 years, 1 month ago (2015-11-03 15:12:20 UTC) #4
reed1
5 years, 1 month ago (2015-11-03 19:26:50 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1420053009/ by reed@google.com.

The reason for reverting is: failing on msaa.

Powered by Google App Engine
This is Rietveld 408576698