Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h

Issue 1410343009: [WIP] Web Animations: Migrate SVG number list interpolation to interpolation types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h
diff --git a/third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.h b/third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h
similarity index 58%
copy from third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.h
copy to third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h
index 05aa0b8e111411b4451b52bc507a8b5ba30989ad..f26add69b9b754f32e87f5f0a68dd7b02b8596e3 100644
--- a/third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.h
+++ b/third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h
@@ -2,19 +2,21 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef SVGNumberInterpolationType_h
-#define SVGNumberInterpolationType_h
+#ifndef SVGNumberListInterpolationType_h
+#define SVGNumberListInterpolationType_h
-#include "core/animation/NumberAttributeFunctions.h"
+#include "core/SVGNames.h"
#include "core/animation/SVGInterpolationType.h"
namespace blink {
-class SVGNumberInterpolationType : public SVGInterpolationType {
+// TODO(alancutter): tspan's rotate attribute is marked as non-additive
+// in the SVG specs
+
+class SVGNumberListInterpolationType : public SVGInterpolationType {
public:
- SVGNumberInterpolationType(const QualifiedName& attribute)
+ SVGNumberListInterpolationType(const QualifiedName& attribute)
: SVGInterpolationType(attribute)
- , m_isNonNegative(NumberAttributeFunctions::isNonNegative(attribute))
{ }
private:
@@ -23,9 +25,9 @@ private:
PassOwnPtr<InterpolationValue> maybeConvertUnderlyingValue(const InterpolationEnvironment&) const final;
RefPtrWillBeRawPtr<SVGPropertyBase> appliedSVGValue(const InterpolableValue&, const NonInterpolableValue*) const final;
- bool m_isNonNegative;
+ PassOwnPtr<PairwisePrimitiveInterpolation> mergeSingleConversions(InterpolationValue& startValue, InterpolationValue& endValue) const final;
};
} // namespace blink
-#endif // SVGNumberInterpolationType_h
+#endif // SVGNumberListInterpolationType_h

Powered by Google App Engine
This is Rietveld 408576698