Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: chrome/renderer/resources/neterror.js

Issue 1410343007: Add "SHOW ALL SAVED PAGES" button to offline error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix after rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page/common/net_error_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index d21700a350145b285e50ee8a85d1027648bd649a..5bab31d8da46ce7cf8399407c02e5649ad3c0efa 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -114,6 +114,12 @@ function showSavedCopyButtonClick() {
}
}
+function showSavedPagesButtonClick() {
+ if (window.errorPageController) {
+ errorPageController.showSavedPagesButtonClick();
+ }
+}
+
function detailsButtonClick() {
if (window.errorPageController)
errorPageController.detailsButtonClick();
@@ -150,13 +156,27 @@ function onDocumentLoad() {
var reloadButton = document.getElementById('reload-button');
var detailsButton = document.getElementById('details-button');
var showSavedCopyButton = document.getElementById('show-saved-copy-button');
+ var showSavedPagesButton = document.getElementById('show-saved-pages-button');
+
+ // "Show save pages" button will only be provided in ERR_INTERNET_DISCONNECTED
+ // page where "Reload" button will not be provided.
+ var reloadButtonVisible = loadTimeData.valueExists('reloadButton') &&
+ loadTimeData.getValue('reloadButton').msg;
+ var showSavedCopyButtonVisible =
+ loadTimeData.valueExists('showSavedCopyButton') &&
+ loadTimeData.getValue('showSavedCopyButton').msg;
+ var showSavedPagesButtonVisible =
+ loadTimeData.valueExists('showSavedPagesButton') &&
+ loadTimeData.getValue('showSavedPagesButton').msg;
var primaryButton, secondaryButton;
if (showSavedCopyButton.primary) {
primaryButton = showSavedCopyButton;
- secondaryButton = reloadButton;
+ secondaryButton =
+ showSavedPagesButtonVisible ? showSavedPagesButton : reloadButton;
} else {
- primaryButton = reloadButton;
+ primaryButton =
+ showSavedPagesButtonVisible ? showSavedPagesButton : reloadButton;
secondaryButton = showSavedCopyButton;
}
@@ -175,7 +195,8 @@ function onDocumentLoad() {
}
if (reloadButton.style.display == 'none' &&
- showSavedCopyButton.style.display == 'none') {
+ showSavedCopyButton.style.display == 'none' &&
+ showSavedPagesButton.style.display == 'none') {
detailsButton.classList.add('singular');
}
@@ -188,17 +209,13 @@ function onDocumentLoad() {
</if>
// Show control buttons.
- if (loadTimeData.valueExists('reloadButton') &&
- loadTimeData.getValue('reloadButton').msg ||
- loadTimeData.valueExists('showSavedCopyButton') &&
- loadTimeData.getValue('showSavedCopyButton').msg) {
+ if (reloadButtonVisible || showSavedCopyButtonVisible ||
+ showSavedPagesButtonVisible) {
controlButtonDiv.hidden = false;
// Set the secondary button state in the cases of two call to actions.
- if (loadTimeData.valueExists('reloadButton') &&
- loadTimeData.getValue('reloadButton').msg &&
- loadTimeData.valueExists('showSavedCopyButton') &&
- loadTimeData.getValue('showSavedCopyButton').msg) {
+ if ((reloadButtonVisible || showSavedPagesButtonVisible) &&
+ showSavedCopyButtonVisible) {
secondaryButton.classList.add('secondary-button');
}
}
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page/common/net_error_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698