chrome/app/generated_resources.grd - Issue 1410343007: Add "SHOW ALL SAVED PAGES" button to offline error page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1410343007: Add "SHOW ALL SAVED PAGES" button to offline error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address more feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/browser/android/tab_android.h » ('j') | chrome/browser/net/net_error_tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 642e156c3fb726e50abf51490d0a2afe72f34f45..1ae558a3ea920833f3d24909a24e11cced542d66 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -8793,6 +8793,14 @@ I don't think this site should be blocked!

Show saved copy

</message>

</if>

+ <if expr="is_android">

+ <message name="IDS_ERRORPAGES_BUTTON_SHOW_SAVED_PAGES" desc="Label for the button on an error page to show saved pages">

newt (away) 2015/11/09 22:15:13 I think you should mention "offline" in the descri

jianli 2015/11/09 23:08:56 Done.

+ Show all saved pages

+ </message>

+ <message name="IDS_ERRORPAGES_BUTTON_SHOW_SAVED_PAGES_HELP" desc="Mobile: Explanation for the BUTTON_SHOW_SAVED_PAGES button">

newt (away) 2015/11/09 22:15:12 Why "Mobile:" here and not on the string above? I'

jianli 2015/11/09 23:08:56 Done.

+ Show all saved pages

+ </message>

+ </if>

The owner of this device turned off the dinosaur game.

</message>