Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1410343005: Update version parameter format in SpdyAltSvcWireFormat. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update version parameter format in SpdyAltSvcWireFormat. Update version parameter of alternative services to a quotation mark enclosed, comma separated list of positive integers (from a single naked integer). Also place it at the end of the list both as a member and when serialized. This makes sense because it is an experimental parameter (as opposed to, for example, max-age, which is serialized first). It was following port previously for more efficient packing, but now that it's a vector, that became moot. This CL lands server change 106303839 by bnc. BUG=392575 Committed: https://crrev.com/50767a82f2be8f62f9d20f2add7f602130e0a305 Cr-Commit-Position: refs/heads/master@{#356300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -60 lines) Patch
M net/spdy/spdy_alt_svc_wire_format.h View 1 chunk +8 lines, -4 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 5 chunks +51 lines, -14 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 10 chunks +21 lines, -18 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 6 chunks +29 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thank you.
5 years, 1 month ago (2015-10-27 13:19:34 UTC) #2
Ryan Hamilton
lgtm
5 years, 1 month ago (2015-10-27 13:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343005/1
5 years, 1 month ago (2015-10-27 14:16:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 15:24:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 15:25:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50767a82f2be8f62f9d20f2add7f602130e0a305
Cr-Commit-Position: refs/heads/master@{#356300}

Powered by Google App Engine
This is Rietveld 408576698