fpdfsdk/src/fpdf_transformpage.cpp - Issue 1410343003: [Merge to XFA] Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_transformpage.cpp

Issue 1410343003: [Merge to XFA] Revert "Revert "Add type cast definitions for CPDF_Dictionary."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Rebase to origin/xfa Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fpdf_transformpage.cpp

diff --git a/fpdfsdk/src/fpdf_transformpage.cpp b/fpdfsdk/src/fpdf_transformpage.cpp

index cdc646ae7e140a9559b1d721fb6dbe9f733db187..1e24b68f08b7e30feff504a9d70d68489b0fc11c 100644

--- a/fpdfsdk/src/fpdf_transformpage.cpp

+++ b/fpdfsdk/src/fpdf_transformpage.cpp

@@ -166,8 +166,8 @@ DLLEXPORT FPDF_BOOL STDCALL FPDFPage_TransFormWithClip(FPDF_PAGE page,

CPDF_Object* pObj = pPattenDict->GetNextElement(pos, key);

if (pObj->GetType() == PDFOBJ_REFERENCE)

pObj = pObj->GetDirect();

- if (pObj->GetType() == PDFOBJ_DICTIONARY) {

- pDict = (CPDF_Dictionary*)pObj;

+ if (pObj->IsDictionary()) {

+ pDict = pObj->AsDictionary();

} else if (pObj->GetType() == PDFOBJ_STREAM) {

pDict = ((CPDF_Stream*)pObj)->GetDict();

} else

« no previous file with comments | « fpdfsdk/src/fpdf_flatten.cpp ('k') | fpdfsdk/src/fpdfdoc.cpp » ('j') | no next file with comments »