[Merge to XFA] Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

core/src/fpdfdoc/doc_ocg.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 static int32_t FPDFDOC_OCG_FindGroup(const CPDF_Object* pObject,
                                      const CPDF_Dictionary* pGroupDict) {
   if (pObject == NULL || pGroupDict == NULL) {
@@ skipping 191 matching lines @@
     return FALSE;
   }
   int32_t iCount = pExpression->GetCount();
   CPDF_Object* pOCGObj;
   CFX_ByteString csOperator = pExpression->GetString(0);
   if (csOperator == FX_BSTRC("Not")) {
     pOCGObj = pExpression->GetElementValue(1);
     if (pOCGObj == NULL) {
       return FALSE;
     }
-    if (pOCGObj->GetType() == PDFOBJ_DICTIONARY) {
-      return !(bFromConfig ? LoadOCGState((CPDF_Dictionary*)pOCGObj)
-                           : GetOCGVisible((CPDF_Dictionary*)pOCGObj));
+    if (CPDF_Dictionary* pDict = pOCGObj->AsDictionary()) {
+      return !(bFromConfig ? LoadOCGState(pDict) : GetOCGVisible(pDict));
     }
     if (pOCGObj->GetType() == PDFOBJ_ARRAY) {
       return !GetOCGVE((CPDF_Array*)pOCGObj, bFromConfig, nLevel + 1);
     }
     return FALSE;
   }
   if (csOperator == FX_BSTRC("Or") || csOperator == FX_BSTRC("And")) {
     FX_BOOL bValue = FALSE;
     for (int32_t i = 1; i < iCount; i++) {
       pOCGObj = pExpression->GetElementValue(1);
       if (pOCGObj == NULL) {
         continue;
       }
       FX_BOOL bItem = FALSE;
-      if (pOCGObj->GetType() == PDFOBJ_DICTIONARY) {
-        bItem = bFromConfig ? LoadOCGState((CPDF_Dictionary*)pOCGObj)
-                            : GetOCGVisible((CPDF_Dictionary*)pOCGObj);
+      if (CPDF_Dictionary* pDict = pOCGObj->AsDictionary()) {
+        bItem = bFromConfig ? LoadOCGState(pDict) : GetOCGVisible(pDict);
       } else if (pOCGObj->GetType() == PDFOBJ_ARRAY) {
         bItem = GetOCGVE((CPDF_Array*)pOCGObj, bFromConfig, nLevel + 1);
       }
       if (i == 1) {
         bValue = bItem;
       } else {
         if (csOperator == FX_BSTRC("Or")) {
           bValue = bValue || bItem;
         } else {
           bValue = bValue && bItem;
         }
       }
     }
     return bValue;
   }
   return FALSE;
 }
 FX_BOOL CPDF_OCContext::LoadOCMDState(const CPDF_Dictionary* pOCMDDict,
                                       FX_BOOL bFromConfig) {
   FXSYS_assert(pOCMDDict != NULL);
   CPDF_Array* pVE = pOCMDDict->GetArray(FX_BSTRC("VE"));
   if (pVE != NULL) {
     return GetOCGVE(pVE, bFromConfig);
   }
   CFX_ByteString csP = pOCMDDict->GetString(FX_BSTRC("P"), FX_BSTRC("AnyOn"));
   CPDF_Object* pOCGObj = pOCMDDict->GetElementValue(FX_BSTRC("OCGs"));
   if (pOCGObj == NULL) {
     return TRUE;
   }
-  if (pOCGObj->GetType() == PDFOBJ_DICTIONARY) {
-    return bFromConfig ? LoadOCGState((CPDF_Dictionary*)pOCGObj)
-                       : GetOCGVisible((CPDF_Dictionary*)pOCGObj);
+  if (const CPDF_Dictionary* pDict = pOCGObj->AsDictionary()) {
+    return bFromConfig ? LoadOCGState(pDict) : GetOCGVisible(pDict);
   }
   if (pOCGObj->GetType() != PDFOBJ_ARRAY) {
     return TRUE;
   }
   FX_BOOL bState = FALSE;
   if (csP == FX_BSTRC("AllOn") || csP == FX_BSTRC("AllOff")) {
     bState = TRUE;
   }
   int32_t iCount = ((CPDF_Array*)pOCGObj)->GetCount();
   for (int32_t i = 0; i < iCount; i++) {
@@ skipping 24 matching lines @@
   CFX_ByteString csType =
       pOCGDict->GetString(FX_BSTRC("Type"), FX_BSTRC("OCG"));
   if (csType == FX_BSTRC("OCG")) {
     return GetOCGVisible(pOCGDict);
   }
   return LoadOCMDState(pOCGDict, FALSE);
 }
 void CPDF_OCContext::ResetOCContext() {
   m_OCGStates.clear();
 }