[Merge to XFA] Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_serial.h"
 CFDF_Document::CFDF_Document() : CPDF_IndirectObjects(NULL) {
   m_pRootDict = NULL;
   m_pFile = NULL;
@@ skipping 52 matching lines @@
       }
       InsertIndirectObject(objnum, pObj);
       word = parser.GetNextWord(bNumber);
       if (word != FX_BSTRC("endobj")) {
         break;
       }
     } else {
       if (word != FX_BSTRC("trailer")) {
         break;
       }
-      CPDF_Dictionary* pMainDict =
-          (CPDF_Dictionary*)parser.GetObject(this, 0, 0, 0);
-      if (pMainDict == NULL || pMainDict->GetType() != PDFOBJ_DICTIONARY) {
-        break;
+      if (CPDF_Dictionary* pMainDict =
+              ToDictionary(parser.GetObject(this, 0, 0, 0))) {
+        m_pRootDict = pMainDict->GetDict(FX_BSTRC("Root"));
+        pMainDict->Release();
       }
-      m_pRootDict = pMainDict->GetDict(FX_BSTRC("Root"));
-      pMainDict->Release();
       break;
     }
   }
 }
 FX_BOOL CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const {
   if (m_pRootDict == NULL) {
     return FALSE;
   }
   buf << FX_BSTRC("%FDF-1.2\r\n");
   FX_POSITION pos = m_IndirectObjs.GetStartPosition();
@@ skipping 45 matching lines @@
     }
     result += ChangeSlash(filepath.c_str() + 2);
   } else if (filepath.GetLength() > 1 && filepath[0] == '\\' &&
              filepath[1] == '\\') {
     result = ChangeSlash(filepath.c_str() + 1);
   } else {
     result = ChangeSlash(filepath.c_str());
   }
   if (pFileSpec->GetType() == PDFOBJ_STRING) {
     pFileSpec->SetString(CFX_ByteString::FromUnicode(result));
-  } else if (pFileSpec->GetType() == PDFOBJ_DICTIONARY) {
-    ((CPDF_Dictionary*)pFileSpec)
-        ->SetAtString(FX_BSTRC("F"), CFX_ByteString::FromUnicode(result));
-    ((CPDF_Dictionary*)pFileSpec)
-        ->SetAtString(FX_BSTRC("UF"), PDF_EncodeText(result));
-    ((CPDF_Dictionary*)pFileSpec)->RemoveAt(FX_BSTRC("FS"));
+  } else if (CPDF_Dictionary* pFileDict = pFileSpec->AsDictionary()) {
+    pFileDict->SetAtString(FX_BSTRC("F"), CFX_ByteString::FromUnicode(result));
+    pFileDict->SetAtString(FX_BSTRC("UF"), PDF_EncodeText(result));
+    pFileDict->RemoveAt(FX_BSTRC("FS"));
   }
 }
 CFX_WideString FPDF_FileSpec_GetWin32Path(const CPDF_Object* pFileSpec) {
   CFX_WideString wsFileName;
-  if (pFileSpec->GetType() == PDFOBJ_DICTIONARY) {
-    CPDF_Dictionary* pDict = (CPDF_Dictionary*)pFileSpec;
+  if (!pFileSpec) {
+    wsFileName = CFX_WideString();
+  } else if (const CPDF_Dictionary* pDict = pFileSpec->AsDictionary()) {
     wsFileName = pDict->GetUnicodeText(FX_BSTRC("UF"));
     if (wsFileName.IsEmpty()) {
       wsFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("F")));
     }
     if (pDict->GetString(FX_BSTRC("FS")) == FX_BSTRC("URL")) {
       return wsFileName;
     }
     if (wsFileName.IsEmpty() && pDict->KeyExist(FX_BSTRC("DOS"))) {
       wsFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("DOS")));
     }
-  } else if (!pFileSpec)
-    wsFileName = CFX_WideString();
-  else {
+  } else {
     wsFileName = CFX_WideString::FromLocal(pFileSpec->GetString());
   }
   if (wsFileName[0] != '/') {
     return ChangeSlash(wsFileName.c_str());
   }
   if (wsFileName[2] == '/') {
     CFX_WideString result;
     result += wsFileName[1];
     result += ':';
     result += ChangeSlash(wsFileName.c_str() + 2);
     return result;
   }
   CFX_WideString result;
   result += '\\';
   result += ChangeSlash(wsFileName.c_str());
   return result;
 }