chrome/installer/util/advanced_firewall_manager_win.cc - Issue 1410333006: Enough hacks to make wstring printfs unneeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/advanced_firewall_manager_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/advanced_firewall_manager_win.cc

diff --git a/chrome/installer/util/advanced_firewall_manager_win.cc b/chrome/installer/util/advanced_firewall_manager_win.cc

index a5fb034e4498d8f984ac017f2dbd8df3e731ea0b..e1adf212fd77a6dd905c6541790c30da291cd3ad 100644

--- a/chrome/installer/util/advanced_firewall_manager_win.cc

+++ b/chrome/installer/util/advanced_firewall_manager_win.cc

@@ -136,8 +136,8 @@ base::win::ScopedComPtr<INetFwRule> AdvancedFirewallManager::CreateUDPRule(

udp_rule->put_Protocol(NET_FW_IP_PROTOCOL_UDP);

udp_rule->put_Direction(NET_FW_RULE_DIR_IN);

udp_rule->put_Enabled(VARIANT_TRUE);

- udp_rule->put_LocalPorts(

- base::win::ScopedBstr(base::StringPrintf(L"%u", port).c_str()));

+/* udp_rule->put_LocalPorts(

+ base::win::ScopedBstr(base::StringPrintf(L"%u", port).c_str()));*/

udp_rule->put_Grouping(base::win::ScopedBstr(app_name_.c_str()));

udp_rule->put_Profiles(NET_FW_PROFILE2_ALL);

udp_rule->put_Action(NET_FW_ACTION_ALLOW);