Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/shell_integration_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/shell_integration_win.cc
diff --git a/chrome/browser/shell_integration_win.cc b/chrome/browser/shell_integration_win.cc
index 4089dc47a12765898c4a3413352e26cabed14faf..c7805a79e9f649ff3cd1a97e58a2aec945a23a53 100644
--- a/chrome/browser/shell_integration_win.cc
+++ b/chrome/browser/shell_integration_win.cc
@@ -261,10 +261,12 @@ void ResetDefaultBrowser() {
for (const wchar_t* format : kUrlAssociationKeyFormats) {
for (const wchar_t* protocol : kProtocols) {
- base::win::RegKey registry_key(
+ (void)format;
+ (void)protocol;
+ /*base::win::RegKey registry_key(
HKEY_CURRENT_USER, base::StringPrintf(format, protocol).c_str(),
KEY_SET_VALUE);
- registry_key.DeleteValue(L"Hash");
+ registry_key.DeleteValue(L"Hash");*/
}
}
}
@@ -513,8 +515,8 @@ int ShellIntegration::MigrateShortcutsInPathInternal(
continue;
}
base::CommandLine command_line(
- base::CommandLine::FromString(base::StringPrintf(
- L"\"%ls\" %ls", target_path.value().c_str(), arguments.c_str())));
+ base::CommandLine::FromString(L""/*base::StringPrintf(
+ L"\"%ls\" %ls", target_path.value().c_str(), arguments.c_str())*/));
// Get the expected AppId for this Chrome shortcut.
base::string16 expected_app_id(

Powered by Google App Engine
This is Rietveld 408576698