base/trace_event/memory_allocator_dump.cc - Issue 1410333006: Enough hacks to make wstring printfs unneeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_allocator_dump.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/memory_allocator_dump.cc

diff --git a/base/trace_event/memory_allocator_dump.cc b/base/trace_event/memory_allocator_dump.cc

index 76d53eb4762730c64ac43f1cf45b25520da0f9a0..6ea09e89b65f99b87f791d50f35d0f59186f3f1d 100644

--- a/base/trace_event/memory_allocator_dump.cc

+++ b/base/trace_event/memory_allocator_dump.cc

@@ -62,7 +62,7 @@ MemoryAllocatorDump::~MemoryAllocatorDump() {

void MemoryAllocatorDump::AddScalar(const char* name,

const char* units,

uint64 value) {

- SStringPrintf(&string_conversion_buffer_, "%" PRIx64, value);

+ /*SStringPrintf(&string_conversion_buffer_, "%" PRIx64, value);*/

attributes_->BeginDictionary(name);

attributes_->SetString("type", kTypeScalar);

attributes_->SetString("units", units);