Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2876)

Unified Diff: base/strings/stringprintf.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/strings/stringprintf.cc
diff --git a/base/strings/stringprintf.cc b/base/strings/stringprintf.cc
index 537873d71c844435a71999c00d3cd5f7d6700565..7f76fb7a071319667fae9c5aa0a3971e23641f9a 100644
--- a/base/strings/stringprintf.cc
+++ b/base/strings/stringprintf.cc
@@ -29,14 +29,14 @@ inline int vsnprintfT(char* buffer,
return base::vsnprintf(buffer, buf_size, format, argptr);
}
-#if defined(OS_WIN)
+/*#if defined(OS_WIN)
inline int vsnprintfT(wchar_t* buffer,
size_t buf_size,
const wchar_t* format,
va_list argptr) {
return base::vswprintf(buffer, buf_size, format, argptr);
}
-#endif
+#endif*/
// Templatized backend for StringPrintF/StringAppendF. This does not finalize
// the va_list, the caller is expected to do that.
@@ -119,7 +119,7 @@ std::string StringPrintf(const char* format, ...) {
return result;
}
-#if defined(OS_WIN)
+/*#if defined(OS_WIN)
std::wstring StringPrintf(const wchar_t* format, ...) {
va_list ap;
va_start(ap, format);
@@ -128,7 +128,7 @@ std::wstring StringPrintf(const wchar_t* format, ...) {
va_end(ap);
return result;
}
-#endif
+#endif*/
std::string StringPrintV(const char* format, va_list ap) {
std::string result;
@@ -145,7 +145,7 @@ const std::string& SStringPrintf(std::string* dst, const char* format, ...) {
return *dst;
}
-#if defined(OS_WIN)
+/*#if defined(OS_WIN)
const std::wstring& SStringPrintf(std::wstring* dst,
const wchar_t* format, ...) {
va_list ap;
@@ -155,7 +155,7 @@ const std::wstring& SStringPrintf(std::wstring* dst,
va_end(ap);
return *dst;
}
-#endif
+#endif*/
void StringAppendF(std::string* dst, const char* format, ...) {
va_list ap;
@@ -164,23 +164,23 @@ void StringAppendF(std::string* dst, const char* format, ...) {
va_end(ap);
}
-#if defined(OS_WIN)
+/*#if defined(OS_WIN)
void StringAppendF(std::wstring* dst, const wchar_t* format, ...) {
va_list ap;
va_start(ap, format);
StringAppendV(dst, format, ap);
va_end(ap);
}
-#endif
+#endif*/
void StringAppendV(std::string* dst, const char* format, va_list ap) {
StringAppendVT(dst, format, ap);
}
-#if defined(OS_WIN)
+/*#if defined(OS_WIN)
void StringAppendV(std::wstring* dst, const wchar_t* format, va_list ap) {
StringAppendVT(dst, format, ap);
}
-#endif
+#endif*/
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698