base/profiler/native_stack_sampler_win.cc - Issue 1410333006: Enough hacks to make wstring printfs unneeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/profiler/native_stack_sampler_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/profiler/native_stack_sampler_win.cc

diff --git a/base/profiler/native_stack_sampler_win.cc b/base/profiler/native_stack_sampler_win.cc

index 203ab94053c5094d6ffed6863f586081cb40dbc4..d859aa36576b0b7933092016da484387b63f45a5 100644

--- a/base/profiler/native_stack_sampler_win.cc

+++ b/base/profiler/native_stack_sampler_win.cc

@@ -208,7 +208,7 @@ std::string GetBuildIDForModule(HMODULE module_handle) {

if (result != kGUIDSize)

return std::string();

RemoveChars(build_id, L"{}-", &build_id);

- build_id += StringPrintf(L"%d", age);

+ //build_id += StringPrintf(L"%d", age);

return WideToUTF8(build_id);

}