Fix crash in shell.cc when reporting exceptions that aren't Errors

Fix crash in shell.cc when reporting exceptions that aren't Errors

BUG=chromium:534746
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/1440cd3d833c7bca7777232b5fd754352010aa3e
Cr-Commit-Position: refs/heads/master@{#31414}

[vogelheim, 2015-10-20 12:59:48]

lgtm

https://codereview.chromium.org/1410333004/diff/1/samples/shell.cc
File samples/shell.cc (right):

https://codereview.chromium.org/1410333004/diff/1/samples/shell.cc#newcode419
samples/shell.cc:419: if (stack_trace.length() > 0) {
nitpick: Since you're checking stack_trace_string validity in the previous if,
you could merge this check into the if above.

(Assuming there's no way that you'd have a valid, non-empty v8::String that
somehow turns into a zero-length Utf8Value.)

[jochen (gone - plz use gerrit), 2015-10-20 13:56:55]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-10-20 13:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1410333004/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2015-10-20 13:57:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410333004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410333004/20001

[commit-bot: I haz the power, 2015-10-20 14:33:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-20 14:34:02]

Patchset 2 (id:??) landed as
https://crrev.com/1440cd3d833c7bca7777232b5fd754352010aa3e
Cr-Commit-Position: refs/heads/master@{#31414}