Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410333003: Move definitions of GrGL basic types (e.g. GrGLenum) to their own header. (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move definitions of GrGL basic types (e.g. GrGLenum) to their own header. Committed: https://skia.googlesource.com/skia/+/2fc11d39d187f932aeeb8f6220089326df75e9a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -59 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -52 lines 0 comments Download
A include/gpu/gl/GrGLTypes.h View 1 chunk +61 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLNameAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRange.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 2 months ago (2015-10-19 15:50:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410333003/1
5 years, 2 months ago (2015-10-19 15:50:50 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-19 15:50:51 UTC) #5
egdaniel
lgtm
5 years, 2 months ago (2015-10-19 15:54:07 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 16:03:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2fc11d39d187f932aeeb8f6220089326df75e9a1

Powered by Google App Engine
This is Rietveld 408576698