Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 141033008: Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003… (Closed)

Created:
6 years, 11 months ago by Stephen White
Modified:
6 years, 11 months ago
Reviewers:
bungeman, borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003. These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined. New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs. New Nexus4 baselines for testimagefilters, spritebitmap GM. R=borenet@google.com TBR=borenet, bungeman BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13191

Patch Set 1 #

Patch Set 2 : Updated to ToT #

Total comments: 2

Patch Set 3 : Add IntelRhb rebaselines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -161 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 1 2 12 chunks +12 lines, -12 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 1 2 12 chunks +12 lines, -12 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 16 chunks +16 lines, -16 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 16 chunks +16 lines, -16 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 2 15 chunks +15 lines, -15 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 12 chunks +12 lines, -12 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 12 chunks +12 lines, -12 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 12 chunks +12 lines, -12 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 12 chunks +12 lines, -12 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
borenet
Rubber stamp lgtm https://codereview.chromium.org/141033008/diff/30001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/141033008/diff/30001/expectations/gm/ignored-tests.txt#newcode42 expectations/gm/ignored-tests.txt:42: displacement Looks like this comment could ...
6 years, 11 months ago (2014-01-27 14:42:27 UTC) #1
Stephen White
On 2014/01/27 14:42:27, borenet wrote: > Rubber stamp lgtm > > https://codereview.chromium.org/141033008/diff/30001/expectations/gm/ignored-tests.txt > File expectations/gm/ignored-tests.txt ...
6 years, 11 months ago (2014-01-27 15:05:21 UTC) #2
Stephen White
Committed patchset #3 manually as r13191 (presubmit successful).
6 years, 11 months ago (2014-01-27 15:05:46 UTC) #3
borenet
6 years, 11 months ago (2014-01-27 15:07:53 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/141033008/diff/30001/expectations/gm/ignored-...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/141033008/diff/30001/expectations/gm/ignored-...
expectations/gm/ignored-tests.txt:42: displacement
On 2014/01/27 14:42:27, borenet wrote:
> Looks like this comment could go away too?

Ah, I misread this.

Powered by Google App Engine
This is Rietveld 408576698