content/browser/frame_host/render_frame_host_impl.cc - Issue 1410313006: Separate RenderViewHost from RenderWidgetHost, part 5: move calls to the RenderWidgetHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1410313006: Separate RenderViewHost from RenderWidgetHost, part 5: move calls to the RenderWidgetHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no functionality change Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 66e303c7014acdd52679293465db1cf9609912df..e1e7c6c4108d6efc1e282755170b795e020c1117 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -40,6 +40,7 @@

#include "content/browser/renderer_host/render_view_host_delegate.h"

#include "content/browser/renderer_host/render_view_host_delegate_view.h"

#include "content/browser/renderer_host/render_view_host_impl.h"

+#include "content/browser/renderer_host/render_widget_host_delegate.h"

#include "content/browser/renderer_host/render_widget_host_impl.h"

#include "content/browser/renderer_host/render_widget_host_view_base.h"

#include "content/browser/wake_lock/wake_lock_service_context.h"

@@ -1895,8 +1896,10 @@ void RenderFrameHostImpl::JavaScriptDialogClosed(

// continuing to run its script and dragging out the process.

// This must be done after sending the reply since RenderView can't close

// correctly while waiting for a response.

- if (is_waiting && dialog_was_suppressed)

- render_view_host_->delegate_->RendererUnresponsive(render_view_host_);

+ if (is_waiting && dialog_was_suppressed) {

+ render_view_host_->GetWidget()->delegate()->RendererUnresponsive(

+ render_view_host_->GetWidget());

+ }

}

// PlzNavigate