Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1410313006: Separate RenderViewHost from RenderWidgetHost, part 5: move calls to the RenderWidgetHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 108f8e92239885ffc7b18b3295cb20875d074ea4..e962c82d3b4941684767eb544af86e3a51bfe5c0 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4220,14 +4220,14 @@ void WebContentsImpl::OnIgnoredUIEvent() {
FOR_EACH_OBSERVER(WebContentsObserver, observers_, DidGetIgnoredUIEvent());
}
-void WebContentsImpl::RendererUnresponsive(RenderViewHost* render_view_host) {
+void WebContentsImpl::RendererUnresponsive(
+ RenderWidgetHostImpl* render_widget_host) {
// Don't show hung renderer dialog for a swapped out RVH.
- if (render_view_host != GetRenderViewHost())
+ if (render_widget_host != GetRenderViewHost()->GetWidget())
return;
- RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(render_view_host);
RenderFrameHostImpl* rfhi =
- static_cast<RenderFrameHostImpl*>(rvhi->GetMainFrame());
+ static_cast<RenderFrameHostImpl*>(GetRenderViewHost()->GetMainFrame());
// Ignore renderer unresponsive event if debugger is attached to the tab
// since the event may be a result of the renderer sitting on a breakpoint.
@@ -4239,7 +4239,7 @@ void WebContentsImpl::RendererUnresponsive(RenderViewHost* render_view_host) {
rfhi->IsWaitingForUnloadACK()) {
// Hang occurred while firing the beforeunload/unload handler.
// Pretend the handler fired so tab closing continues as if it had.
- rvhi->set_sudden_termination_allowed(true);
+ GetRenderViewHost()->set_sudden_termination_allowed(true);
if (!GetRenderManager()->ShouldCloseTabOnUnresponsiveRenderer())
return;
@@ -4255,7 +4255,7 @@ void WebContentsImpl::RendererUnresponsive(RenderViewHost* render_view_host) {
delegate_->BeforeUnloadFired(this, true, &close);
}
if (close)
- Close(rvhi);
+ Close();
return;
}
@@ -4266,7 +4266,8 @@ void WebContentsImpl::RendererUnresponsive(RenderViewHost* render_view_host) {
delegate_->RendererUnresponsive(this);
}
-void WebContentsImpl::RendererResponsive(RenderViewHost* render_view_host) {
+void WebContentsImpl::RendererResponsive(
+ RenderWidgetHostImpl* render_widget_host) {
if (delegate_)
delegate_->RendererResponsive(this);
}

Powered by Google App Engine
This is Rietveld 408576698