Web Animations: Use a single animation clock

Web Animations: Use a single animation clock

All animation clocks for a page should tick at the same time, but since we
had an animation clock per document there were some cases where clocks
could tick independently.

This patch moves the clock from Document to PageAnimator.
animation-timeline-detached-no-crash.html is removed as the test was not valid
due to the animation's document not being active.

Committed: https://crrev.com/1bdb2cb318172358647853128a3d3db3f1c7c97a
Cr-Commit-Position: refs/heads/master@{#357736}

[dstockwell, 2015-10-28 03:08:35]

dstockwell@chromium.org changed reviewers:
+ samli@chromium.org

[dstockwell, 2015-10-28 03:08:40]

The CQ bit was checked by dstockwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 03:08:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/1

[commit-bot: I haz the power, 2015-10-28 04:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 04:10:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[samli, 2015-10-28 16:46:50]

lgtm!! This was definitely the source of our invariant breaking.

[dstockwell, 2015-10-29 01:29:16]

The CQ bit was checked by dstockwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 01:29:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/40001

[commit-bot: I haz the power, 2015-10-29 02:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 02:23:17]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dstockwell, 2015-10-29 02:32:31]

The CQ bit was checked by dstockwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 02:33:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/60001

[dstockwell, 2015-10-29 04:50:33]

The CQ bit was checked by dstockwell@chromium.org

[dstockwell, 2015-10-29 04:50:34]

The patchset sent to the CQ was uploaded after l-g-t-m from samli@chromium.org
Link to the patchset: https://codereview.chromium.org/1410313004/#ps100001
(title: "New layout test for real")

[commit-bot: I haz the power, 2015-10-29 04:51:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/100001

[commit-bot: I haz the power, 2015-10-29 05:59:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-29 06:00:39]

Patchset 6 (id:??) landed as
https://crrev.com/b45c39903df3727d21cbc217a0b14c2c85b0715a
Cr-Commit-Position: refs/heads/master@{#356776}

[Peter Kasting, 2015-10-29 22:02:07]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1417613005/ by pkasting@chromium.org.

The reason for reverting is: Caused animation tests to be flaky on all
platforms, especially Android; see http://crbug.com/549318 ..

[dstockwell, 2015-10-29 23:38:39]

Relanding with fix for flaky unit tests.

[dstockwell, 2015-10-29 23:38:47]

The CQ bit was checked by dstockwell@chromium.org

[dstockwell, 2015-10-29 23:38:48]

The patchset sent to the CQ was uploaded after l-g-t-m from samli@chromium.org
Link to the patchset: https://codereview.chromium.org/1410313004/#ps120001
(title: "Use near comparison due to unspecified zero time")

[commit-bot: I haz the power, 2015-10-29 23:39:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/120001

[commit-bot: I haz the power, 2015-10-30 03:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 03:06:54]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[dstockwell, 2015-10-30 03:08:45]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2015-10-30 03:09:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/120001

[commit-bot: I haz the power, 2015-10-30 04:30:51]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-10-30 04:31:36]

Patchset 7 (id:??) landed as
https://crrev.com/ddd06a6080e1e7d7d02b15595289940980b04973
Cr-Commit-Position: refs/heads/master@{#357044}

[Peter Kasting, 2015-10-30 07:45:50]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1425143006/ by pkasting@chromium.org.

The reason for reverting is: Still breaks the Android bot (at least):
https://build.chromium.org/p/chromium.webkit/waterfall?show=WebKit%20Android%...

Please do not reland without first ensuring you have run the webkit_unit_tests
step a few times on an equivalent Android bot..

[dstockwell, 2015-11-02 02:18:12]

The CQ bit was checked by dstockwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 02:18:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/140001

[dstockwell, 2015-11-02 02:35:50]

Description was changed from

==========
Web Animations: Use a single animation clock

All animation clocks for a page should tick at the same time, but since we
had an animation clock per document there were some cases where clocks
could tick independently.

This patch moves the clock from Document to PageAnimator.
animation-timeline-detached-no-crash.html is removed as the test was not valid
due to the animation's document not being active.

Committed: https://crrev.com/b45c39903df3727d21cbc217a0b14c2c85b0715a
Cr-Commit-Position: refs/heads/master@{#356776}

Committed: https://crrev.com/ddd06a6080e1e7d7d02b15595289940980b04973
Cr-Commit-Position: refs/heads/master@{#357044}
==========

to

==========
Web Animations: Use a single animation clock

All animation clocks for a page should tick at the same time, but since we
had an animation clock per document there were some cases where clocks
could tick independently.

This patch moves the clock from Document to PageAnimator.
animation-timeline-detached-no-crash.html is removed as the test was not valid
due to the animation's document not being active.
==========

[commit-bot: I haz the power, 2015-11-02 05:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 05:13:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[dstockwell, 2015-11-04 01:21:50]

Ran testKeyboardDismissedAfterClickingGo locally and on linux_android_rel_ng and
could not reproduce the flakiness from
https://code.google.com/p/chromium/issues/detail?id=549309

Verified that the flaky unit tests have been resolved in the latest patch set
locally (there's no try bot for andriod layout tests afaict).

I'll watch the tree after landing.

[dstockwell, 2015-11-04 01:21:54]

The CQ bit was checked by dstockwell@chromium.org

[dstockwell, 2015-11-04 01:21:55]

The patchset sent to the CQ was uploaded after l-g-t-m from samli@chromium.org
Link to the patchset: https://codereview.chromium.org/1410313004/#ps160001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-11-04 01:24:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410313004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410313004/160001

[commit-bot: I haz the power, 2015-11-04 02:50:42]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-11-04 02:51:17]

Patchset 9 (id:??) landed as
https://crrev.com/1bdb2cb318172358647853128a3d3db3f1c7c97a
Cr-Commit-Position: refs/heads/master@{#357736}