Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 14103024: Do not call preDraw for NOOP. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPicturePlayback.cpp
diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp
index 22125ee02b0de4330667cfaa87a0185bd6023260..47d6c6eb821879aeabe1e27843e9855ea903ac58 100644
--- a/src/core/SkPicturePlayback.cpp
+++ b/src/core/SkPicturePlayback.cpp
@@ -716,11 +716,6 @@ void SkPicturePlayback::draw(SkCanvas& canvas) {
uint32_t size;
DrawType op = read_op_and_size(&reader, &size);
size_t skipTo = 0;
robertphillips 2013/05/21 19:47:11 remove "0 == skipTo" check.
-#ifdef SK_DEVELOPER
- // TODO: once chunk sizes are in all .skps just use
- // "curOffset + size"
- skipTo = this->preDraw(curOffset, op);
-#endif
if (0 == skipTo && NOOP == op) {
// NOOPs are to be ignored - do not propagate them any further
skipTo = curOffset + size;
@@ -742,6 +737,11 @@ void SkPicturePlayback::draw(SkCanvas& canvas) {
reader.setOffset(skipTo);
continue;
}
+#ifdef SK_DEVELOPER
+ // TODO: once chunk sizes are in all .skps just use
+ // "curOffset + size"
+ skipTo = this->preDraw(curOffset, op);
+#endif
switch (op) {
case CLIP_PATH: {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698