Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3089)

Unified Diff: chrome/browser/webdata/web_data_service_factory.cc

Issue 14103021: Use Observer to notify of WebDB load instead of callbacks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix WIN builds Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service_factory.cc
diff --git a/chrome/browser/webdata/web_data_service_factory.cc b/chrome/browser/webdata/web_data_service_factory.cc
index 3ac44328c358f16da865290213ebad4fe0d54373..e1dec21985c3b668ba9ff562bdd1dc0320e0e1cf 100644
--- a/chrome/browser/webdata/web_data_service_factory.cc
+++ b/chrome/browser/webdata/web_data_service_factory.cc
@@ -80,9 +80,7 @@ WebDataServiceWrapper::WebDataServiceWrapper(Profile* profile) {
web_database_->AddTable(
scoped_ptr<WebDatabaseTable>(new WebIntentsTable()));
- // TODO (caitkp): Rework the callbacks here. They're ugly.
-
- web_database_->LoadDatabase(WebDatabaseService::InitCallback());
+ web_database_->LoadDatabase();
autofill_web_data_ = new AutofillWebDataService(
web_database_, base::Bind(&ProfileErrorCallback));

Powered by Google App Engine
This is Rietveld 408576698