Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller.cc

Issue 14103021: Use Observer to notify of WebDB load instead of callbacks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix WIN builds Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/autofill_data_type_controller.cc b/chrome/browser/sync/glue/autofill_data_type_controller.cc
index 6e7a83c016d539988d17e0898cd030e32129d278..f86e3abb4f279f60cfd25edcb9d1d788e1ea0017 100644
--- a/chrome/browser/sync/glue/autofill_data_type_controller.cc
+++ b/chrome/browser/sync/glue/autofill_data_type_controller.cc
@@ -41,7 +41,7 @@ void AutofillDataTypeController::WebDatabaseLoaded() {
DCHECK_EQ(MODEL_STARTING, state());
if (web_data_service_)
- web_data_service_->RemoveObserver(this);
+ web_data_service_->RemoveDBObserver(this);
OnModelLoaded();
}
@@ -49,7 +49,7 @@ void AutofillDataTypeController::WebDatabaseLoaded() {
AutofillDataTypeController::~AutofillDataTypeController() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
if (web_data_service_)
- web_data_service_->RemoveObserver(this);
+ web_data_service_->RemoveDBObserver(this);
}
bool AutofillDataTypeController::PostTaskOnBackendThread(
@@ -68,7 +68,8 @@ bool AutofillDataTypeController::StartModels() {
if (web_data_service_->IsDatabaseLoaded()) {
return true;
} else {
- web_data_service_->AddObserver(this);
+ if (web_data_service_)
+ web_data_service_->AddDBObserver(this);
return false;
}
}
@@ -78,7 +79,7 @@ void AutofillDataTypeController::StopModels() {
DCHECK(state() == STOPPING || state() == NOT_RUNNING || state() == DISABLED);
DVLOG(1) << "AutofillDataTypeController::StopModels() : State = " << state();
if (web_data_service_)
- web_data_service_->RemoveObserver(this);
+ web_data_service_->RemoveDBObserver(this);
}
void AutofillDataTypeController::StartAssociating(

Powered by Google App Engine
This is Rietveld 408576698