chrome/browser/webdata/web_data_service_factory.cc - Issue 14103021: Use Observer to notify of WebDB load instead of callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/web_data_service_factory.cc

Issue 14103021: Use Observer to notify of WebDB load instead of callbacks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: First round of comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/webdata/web_data_service_factory.cc

diff --git a/chrome/browser/webdata/web_data_service_factory.cc b/chrome/browser/webdata/web_data_service_factory.cc

index c07d5fb9ca1cbfc8f3549f4218bccf1551427dcf..92e552aade760b3bb88338943d16e12cd6763383 100644

--- a/chrome/browser/webdata/web_data_service_factory.cc

+++ b/chrome/browser/webdata/web_data_service_factory.cc

@@ -80,9 +80,7 @@ WebDataServiceWrapper::WebDataServiceWrapper(Profile* profile) {

web_database_->AddTable(

scoped_ptr<WebDatabaseTable>(new WebIntentsTable()));

- // TODO (caitkp): Rework the callbacks here. They're ugly.

- web_database_->LoadDatabase(WebDatabaseService::InitCallback());

+ web_database_->LoadDatabase();

autofill_web_data_ = new AutofillWebDataService(

web_database_, base::Bind(&ProfileErrorCallback));