Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1410293007: win/clang: Lame workaround for a compiler bug. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/clang: Lame workaround for a compiler bug. No intended behavior change, but it should get the clang/win tester bots back green while this is being fixed upstream. Hopefully it won't be in the tree for too long. BUG=549765 Committed: https://crrev.com/12293c13ad9e63c152e0f6909085e9a2f01474ee Cr-Commit-Position: refs/heads/master@{#357296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 1 month ago (2015-11-01 20:43:19 UTC) #2
estark
lgtm, thanks!
5 years, 1 month ago (2015-11-01 23:09:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410293007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410293007/1
5 years, 1 month ago (2015-11-02 00:09:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 00:12:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12293c13ad9e63c152e0f6909085e9a2f01474ee Cr-Commit-Position: refs/heads/master@{#357296}
5 years, 1 month ago (2015-11-02 00:13:32 UTC) #7
Nico
5 years ago (2015-12-03 23:44:19 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1494263003/ by thakis@chromium.org.

The reason for reverting is: The compiler bug should now be fixed..

Powered by Google App Engine
This is Rietveld 408576698