runtime/bin/platform_win.cc - Issue 1410293006: Use ExitProcess on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/platform_win.cc

Issue 1410293006: Use ExitProcess on Windows. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/platform_win.cc

diff --git a/runtime/bin/platform_win.cc b/runtime/bin/platform_win.cc

index 9830db2c9ebc863856023aca91260b7105a7d650..df630ea6070de047d7d90cb4167af7a51aa24bdc 100644

--- a/runtime/bin/platform_win.cc

+++ b/runtime/bin/platform_win.cc

@@ -105,6 +105,11 @@ char* Platform::ResolveExecutablePath() {

return canon_path;

}

+void Platform::Exit(int exit_code) {

+ // On Windows we use ExitProcess so that threads can't clobber the exit_code.

Cutch 2015/10/28 20:33:15 Can you include the NaCl issue in a comment here f

zra 2015/10/28 21:40:04 Done.

+ ::ExitProcess(exit_code);

} // namespace bin

} // namespace dart