Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 1410263002: Revert https://codereview.chromium.org/1408263002/ for remoting_host_prefpane. (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert https://codereview.chromium.org/1408263002/ for remoting_host_prefpane. See comment 3 on the bug for details. BUG=544531 TBR=lambroslambrou Committed: https://crrev.com/cf8e2584c690b8512d3f8aaea6f3bcf11d48ba26 Cr-Commit-Position: refs/heads/master@{#354689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M remoting/remoting_host_mac.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
5 years, 2 months ago (2015-10-17 19:14:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410263002/1
5 years, 2 months ago (2015-10-17 19:15:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/54832)
5 years, 2 months ago (2015-10-17 19:19:06 UTC) #6
Nico
Committed patchset #1 (id:1) to pending queue manually as 539cba236710b56e4154030db7521da46367f57f (presubmit successful).
5 years, 2 months ago (2015-10-17 19:19:27 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-17 19:24:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf8e2584c690b8512d3f8aaea6f3bcf11d48ba26
Cr-Commit-Position: refs/heads/master@{#354689}

Powered by Google App Engine
This is Rietveld 408576698