Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410243007: Add a new method to QuicSpdySession (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106714904
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new method to QuicSpdySession Add a public method OnHeadersHeadOfLineBlocking() which does nothing. This method is used to replace EXPECT_CALL(Log()) in quic headers stream test. Merge internal change: 106716057 R=rtennet@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -50 lines) Patch
M net/quic/quic_chromium_client_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 5 chunks +6 lines, -47 lines 0 comments Download
M net/quic/quic_spdy_session.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1411223011 Patch 1

Dependent Patchsets:

Issue 1418213011 Patch 1

Messages

Total messages: 4 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 23:31:01 UTC) #1
ramant (doing other things)
5 years, 1 month ago (2015-11-03 00:26:34 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698