Issue 141023002: Label IPv6 reachability checks in NetLog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141023002: Label IPv6 reachability checks in NetLog (Closed)

Created:
6 years, 11 months ago by Deprecated (see juliatuttle)

Modified:
6 years, 11 months ago

Reviewers:
szym

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Label IPv6 reachability checks in NetLog Chrome's internal DNS resolver checks whether the host currently has global IPv6 connectivity by creating a socket connected to Google Public DNS' IPv6 address. These show up in the NetLog as UDP_SOCKET objects with a source dependency of the HOST_RESOLVER_IMPL_REQUEST. This change adds an explicit IPV6_REACHABILITY_CHECK source type that will show up instead, to clarify the purpose of the UDP sockets. (Note that no packets are actually sent as a result of the checks; UDP doesn't need to send any packets to connect, and the HostResolverImpl doesn't send any data over the socket explicitly.) BUG=331746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245336

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -1 line)			Patch
M	net/base/net_log_event_type_list.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/base/net_log_source_type_list.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/dns/host_resolver_impl.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/141023002/1

6 years, 11 months ago (2014-01-16 19:19:26 UTC) #3

Message was sent while issue was closed.

Change committed as 245336

Expand Messages | Collapse Messages